qt: warn about rescan in wallet migration dialogs#943
Conversation
Migrating a legacy wallet triggers a blockchain rescan immediately after conversion. Depending on the chain size and whether -blockfilterindex is active, this rescan can take anywhere from minutes to hours, with no visual indication that anything is happening. Add a rescan warning to the informative text of both migration confirmation dialogs (migrate and restore-and-migrate) so users can plan accordingly before clicking Confirm. Also update the progress dialog label in do_migrate() to state that a blockchain rescan will follow migration, giving users context while the operation runs. Fixes bitcoin-core#930
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. |
|
Hi @hebasto @fanquake , gentle ping on this one! This is a small UX-only fix for wallet migration, no logic or behaviour changes, purely informational text updates confined to Problem: migrating a legacy wallet silently triggers a blockchain rescan that can take minutes to hours. The progress dialog just shows Three text-only changes in
Out of scope (noted for clarity): separating the migration step from the rescan would require wallet backend changes, this PR intentionally doesn't touch that. Happy to adjust the wording if it doesn't match the tone used elsewhere in the Qt dialogs. Fixes #930. |
2 participants
Problem
Fixes #930.
Migrating a legacy wallet triggers an automatic blockchain rescan
immediately after the conversion completes. Depending on chain size
and whether
-blockfilterindexis enabled, this rescan can takeanywhere from minutes to hours. During this time the progress dialog
shows "Migrating Wallet…" with no indication that a rescan is
happening — only the debug log reveals what is going on.
Fix
Three changes, all in
MigrateWalletActivity:1 & 2 — Confirmation dialogs (
migrate()andrestore_and_migrate()): append a rescan warning to the informativetext so users know what to expect before clicking Confirm:
3 — Progress dialog (
do_migrate()): update the label from thebare "Migrating Wallet…" to also mention the rescan, so users who are
already in the waiting phase have context:
Notes
src/qt/walletcontroller.cpp.text.
migrateWallet()as a singleblocking call; separating migration from rescan would require wallet
backend changes and is out of scope here.